POWER:BAT: clarified the sign for the current fields#73
Open
Claudio-Chies wants to merge 2 commits intodronecan:masterfrom
Open
POWER:BAT: clarified the sign for the current fields#73Claudio-Chies wants to merge 2 commits intodronecan:masterfrom
Claudio-Chies wants to merge 2 commits intodronecan:masterfrom
Conversation
dakejahl
approved these changes
Sep 5, 2025
MaEtUgR
approved these changes
Sep 8, 2025
MaEtUgR
left a comment
MaEtUgR
left a comment
There was a problem hiding this comment.
This is unclear in the original definition.
Author
|
Realized that the CBAT message suffers from the same issues, added units and definitions to it aswell. |
Claudio-Chies
force-pushed
the
pr-clarify_bat_msgs
branch
from
c9fc8fd to
d0ae031
Compare
Author
|
@tridge would be happy for feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
From the Message definition of BatteryInfo and BatteryInfoAux it it not clear if a discharge current should be positive or negative, which has lead different manufacturers to implement it differently, (E.g CUAV CAN power module, reports positive current for discharging, and TATTU Smart Battery reports negative current for discharging)
The same issue for the CUAV CBAT message, no units were present for any of the fields.
Solution: